ENH: consistency of input args for boundaries in DataFrame.between_time() #40245 #43248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
suyashgupta01
commented
Aug 27, 2021
•
suyashgupta01
commented
- xref ENH: consistency of input args for boundaries #40245
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
MarcoGorelli
requested changes
Aug 30, 2021
suyashgupta01
force-pushed
the
new-boundary-inputs-pandas.DataFrame.between_time
branch
from
79bcde4
to
6e9882d
Compare
|
@MarcoGorelli can you approve the workflows, please? |
|
@jreback It's all green, take a look :) |
|
@jreback Are any other changes required? |
jreback
approved these changes
Sep 9, 2021
|
lgtm @attack68 @MarcoGorelli if any comments. |
MarcoGorelli
requested changes
Sep 10, 2021
pandas/core/generic.py
Outdated
| inclusive = "both" | ||
| elif inclusive not in ["both", "neither", "left", "right"]: | ||
| raise ValueError( | ||
| f"Inclusive has to be either string of 'both'," |
There was a problem hiding this comment.
Suggested change
| f"Inclusive has to be either string of 'both'," | |
| f"Inclusive has to be either string of 'both', " |
There was a problem hiding this comment.
the test will need updating here as well
Co-authored-by: Marco Edward Gorelli <marcogorelli@protonmail.com>
Co-authored-by: Marco Edward Gorelli <marcogorelli@protonmail.com>
|
@MarcoGorelli Made the requested changes, please take a look :) |
MarcoGorelli
approved these changes
Sep 10, 2021
|
@attack68 your review's pending, please take a look :) |
|
@MarcoGorelli Can you please take a look at the failing check, I can't figure out why it is failing? |
|
it's unrelated, don't worry about it |
|
thanks @suyashgupta01 ver nice |
suyashgupta01
deleted the
new-boundary-inputs-pandas.DataFrame.between_time
branch
4 tasks
zhengruifeng
pushed a commit
to apache/spark
that referenced
this pull request
Aug 18, 2023
…exer_between_time` for pandas 2.0.0 & enabling more tests ### What changes were proposed in this pull request? This PR proposes to support `DatetimeIndex.indexer_between_time` to support pandas 2.0.0 and above. See pandas-dev/pandas#43248 for more detail. This PR also enables bunch of tests for `Series`, `Index` and `GroupBy`. ### Why are the changes needed? To match the behavior with latest pandas. ### Does this PR introduce _any_ user-facing change? `DatetimeIndex.indexer_between_time` now has the same behavior with the latest pandas. ### How was this patch tested? Enabling & updating the existing UTs and doctests. Closes #42533 from itholic/enable-many-tests. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
valentinp17
pushed a commit
to valentinp17/spark
that referenced
this pull request
Aug 24, 2023
…exer_between_time` for pandas 2.0.0 & enabling more tests ### What changes were proposed in this pull request? This PR proposes to support `DatetimeIndex.indexer_between_time` to support pandas 2.0.0 and above. See pandas-dev/pandas#43248 for more detail. This PR also enables bunch of tests for `Series`, `Index` and `GroupBy`. ### Why are the changes needed? To match the behavior with latest pandas. ### Does this PR introduce _any_ user-facing change? `DatetimeIndex.indexer_between_time` now has the same behavior with the latest pandas. ### How was this patch tested? Enabling & updating the existing UTs and doctests. Closes apache#42533 from itholic/enable-many-tests. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
…exer_between_time` for pandas 2.0.0 & enabling more tests ### What changes were proposed in this pull request? This PR proposes to support `DatetimeIndex.indexer_between_time` to support pandas 2.0.0 and above. See pandas-dev/pandas#43248 for more detail. This PR also enables bunch of tests for `Series`, `Index` and `GroupBy`. ### Why are the changes needed? To match the behavior with latest pandas. ### Does this PR introduce _any_ user-facing change? `DatetimeIndex.indexer_between_time` now has the same behavior with the latest pandas. ### How was this patch tested? Enabling & updating the existing UTs and doctests. Closes apache#42533 from itholic/enable-many-tests. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.